From 4566441d8c9f9b7ea07aefe5f11dedf1c3ed07ed Mon Sep 17 00:00:00 2001 From: Lukas Halbritter Date: Fri, 28 Sep 2018 22:42:51 +0200 Subject: [PATCH] The SubBooking factory now uses the abs() function to generate values, since amount is an absolute value and the sign is stored as property of the i_o_type. --- database/factories/SubBookingFactory.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/database/factories/SubBookingFactory.php b/database/factories/SubBookingFactory.php index 8d78288..624c492 100644 --- a/database/factories/SubBookingFactory.php +++ b/database/factories/SubBookingFactory.php @@ -19,27 +19,27 @@ $factory->define(App\SubBooking::class, function (Faker $faker) { // Overpaid if ($randomPersonTarget->ioType->name === 'Einnahme') { $randomAccountType = AccountType::incomes()->random(); - $amount = $randomPersonTarget->difference() + rand(1, 100); + $amount = abs($randomPersonTarget->difference() + rand(1, 100)); } else { $randomAccountType = AccountType::expeditures()->random(); - $amount = $randomPersonTarget->difference() + rand(1, 100); + $amount = abs($randomPersonTarget->difference() + rand(1, 100)); } } else if (rand_bool(20)) { // Underpaid if ($randomPersonTarget->ioType->name === 'Einnahme') { $randomAccountType = AccountType::incomes()->random(); - $amount = $randomPersonTarget->difference() - rand(1, $randomPersonTarget->difference()); + $amount = abs($randomPersonTarget->difference() - rand(1, $randomPersonTarget->difference())); } else { $randomAccountType = AccountType::expeditures()->random(); - $amount = $randomPersonTarget->difference() - rand(1, $randomPersonTarget->difference()); + $amount = abs($randomPersonTarget->difference() - rand(1, $randomPersonTarget->difference())); } } else { if ($randomPersonTarget->ioType->name === 'Einnahme') { $randomAccountType = AccountType::incomes()->random(); - $amount = $randomPersonTarget->difference(); + $amount = abs($randomPersonTarget->difference()); } else { $randomAccountType = AccountType::expeditures()->random(); - $amount = $randomPersonTarget->difference(); + $amount = abs($randomPersonTarget->difference()); } }